Re: [libvirt] PATCH: Fix non-raw storage volume cloning
On Fri, Jul 17, 2009 at 01:08:11PM +0100, Daniel P. Berrange wrote:
The recent storage patches broke cloning of non-raw volumes, due to a
small typo. THis was identified by the libvirt TCK storage tests!
ACK !
BTW the enum defining the tool doesn't provide an initializer
I usually prefer to set one up like
enum {
TOOL_QEMU_IMG = 1,
...
To be sure what to expect in the code, even if it is supposed to start
from zero, currently we compare a value that the compiler choose to
define to a -1 (or < 0) arbitrary check. It works but I feel a bit
uneasy about this :-)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/