Re: [libvirt] [PATCH 0/7] Introduce API for dumping domain IP addresses
On 06/08/2012 08:13 AM, Eric Blake wrote:
On 06/08/2012 02:04 AM, Michal Privoznik wrote:
> This feature has been requested for a very long time. However,
> we had to wait for guest agent to obtain reliable results as
> user might create totally different structure of interfaces than
> seen from outside (e.g. bonding, virtual interfaces, etc.).
> That's the main reason why sniffing for domain traffic can
> return bogus results. Fortunately, qemu guest agent implement
> requested part for a while so nothing holds us back anymore.
How hard would it be to wire this API up to _also_ have the option of
using our nwfilter IP learning code (first packet detection mode has
been here for a while, and DHCP snooping mode was just added)? Use of
the flags parameter should make it possible to force which method we
attempt, use of flags==0 chooses the best method possible (GA if
present, otherwise fall back to nwfilter IP learning).
I would have to change some things in the still outstanding patch 5/5 to
provide calls to pull an array of virIPLease (= virSocketAddr + time_t)
from the DHCP Snooping and Learning code rather tan having them write
their stuff into a buffer. I'll fix this. This should then make it a lot
easier to pull that data. Either method may return no array if it has
not been activated.
Stefan