Re: [libvirt] [PATCH 2/2] maint: syntax check for double semicolons
On 09/04/2014 09:55 AM, Nehal J Wani wrote:
On Thu, Sep 4, 2014 at 8:32 PM, Eric Blake <eblake(a)redhat.com>
wrote:
> Commit 28de556 fixed some doubled semicolons, but failed to
> add a syntax check, and thereby missed another instance. This
> finishes the job (and also found an instance in gnulib, prior
> to the previous patch's submodule update).
>
> * cfg.mk (sc_prohibit_double_semicolon): New rule.
> * src/xenconfig/xen_common.c (xenFormatConfigCommon): Fix offender.
>
ACK
Actually, I'm going to post a v2 once the dust settles upstream; the
gnulib folks liked my idea so much they asked for it to be included
upstream into gnulib, with some slight changes:
https://lists.gnu.org/archive/html/bug-gnulib/2014-09/msg00024.html
which means I should just get it from gnulib instead of duplicating it
into our cfg.mk.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 539 bytes)