Re: [libvirt] PATCH: Clean up QEMU driver argv builder

On Thu, May 22, 2008 at 05:34:19PM +0100, Daniel P. Berrange wrote: > Daniel pointed out that the way we build up the QEMU argv strnig is becoming > rather unscalable / error prone. This patch refactors it into to use a short > macro to do memory allocation/reallocation, which clears it up quite nicely Yup, thanks a lot, easier to read and check ! +1 I always feel a bit surprized by macro defined within functions, but I don't have a good rationale for not doing this :-) (maybe not suggest the scope might be limited to the function)