Re: [libvirt] [PATCH] qemu: snapshot: Don't mark all block disks for metadata reuse

On 06/16/2014 06:29 AM, Peter Krempa wrote: > For block devices used as snapshot source the new snapshot code would > set the reuse flag. This inhibits to take snapshot without specially > preparing the block image before taking the snapshot. > > Fortunately this is not a regression as only the new way of specifying > snapshot source is affected. > > For the followin snapshot XML: > <domainsnapshot> > <disks> > <disk name='vda' type='block'> > <driver type='qcow2'/> > <source dev="/dev/andariel/testsnap" /> > </disk> > </disks> > </domainsnapshot> > > You'd get: > error: internal error: unable to execute QEMU command 'transaction': Image is not in qcow2 format > > After this patch the snapshot is created successfully. > --- > src/qemu/qemu_driver.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) ACK.