Re: [libvirt] [PATCH] bhyve: bhyveload: respect boot dev and boot order
Daniel P. Berrange wrote:
On Sun, Dec 13, 2015 at 06:41:21AM +0300, Roman Bogorodskiy wrote:
> Make bhyveload respect boot order as specified by os.boot section of the
> domain XML or by "boot order" for specific devices. As bhyve does not
> support a real boot order specification right now, it's just about
> choosing a single device to boot from.
So if bhyve only lets you specify a single device to boot from,
then we should report an error to the user if they provide more
than one <boot> element in the XML.
The reason that I did it this way was because my original intention was
to make it work with virt-manager smoother. However, I think you're
right, it's better to error on configuration we cannot properly support
instead of letting users have false expectation.
It will make creation of new VM via virt-manager fail with the default
configuration, but it's not critical because user still have to modify
some hardware settings anyway to make it work with bhyve (i.e.: drop vnc
and pty console).
Thanks for the review, I'll upload v2 shortly.
Roman Bogorodskiy