Re: [PATCH v2 0/9] move checks from parse to validate callbacks
On 12/8/20 6:45 PM, Daniel Henrique Barboza wrote:
On 12/8/20 7:22 AM, Michal Privoznik wrote:
>
> But since we are splitting parsing and validation code can we use this
> chance and move validators out of domain_conf.c allowing it to be
> smaller in size?
Makes sense. I can create a 'domain_validate.c' and start moving stuff
there,
like I did previously with QEMU driver validations and qemu_validate.c.
First order of business would be to move the validations I already played
with in this series to this new file.
What do you think?
Yes, qemu_validate.c example was what I had on mind. I don't have
preference whether to move everything at once or by smaller pieces (how
small?). While the latter might look like easier to review, not really
since git diff has now --color-moved. That way a reviewer can verify
that a commit is just moving code.
Michal