Re: [libvirt] [PATCH 2/6] secret: util: Refactor virSecretGetSecretString

Call the internal driver callbacks rather than the public APIs to avoid calling unnecessarily the error dispatching code and don't overwrite the error messages provided by the APIs. They are good enough to describe which secret is missing either by UUID or the usage (basically name). --- po/POTFILES.in | 1 - src/libxl/libxl_conf.c | 3 --- src/qemu/qemu_domain.c | 4 +--- src/secret/secret_util.c | 39 +++++++-------------------------------- src/secret/secret_util.h | 1 - 5 files changed, 8 insertions(+), 40 deletions(-)

--- a/src/secret/secret_util.h +++ b/src/secret/secret_util.h @@ -26,7 +26,6 @@ # include "virstoragefile.h" char *virSecretGetSecretString(virConnectPtr conn, - const char *scheme, bool encoded, virStorageAuthDefPtr authdef, virSecretUsageType secretUsageType)