Re: [libvirt] [PATCH] Query block allocation extent from QEMU monitor

On 05/14/2010 07:10 AM, Daniel P. Berrange wrote: > The virDomainGetBlockInfo API allows query physical block > extent and allocated block extent. These are normally the > same value unless storing a special format like qcow2 > inside a block device. In this scenario we can query QEMU > to get the actual allocated extent. > > Since last time: > > - Return fatal error in text monitor Good, but... > - ret = 0; > + /* ..but if guest is running & not using raw > + disk format and on a block device, then query > + highest allocated extent from QEMU */ > + if (virDomainObjIsActive(vm) && > + disk->type == VIR_DOMAIN_DISK_TYPE_BLOCK && > + meta.format != VIR_STORAGE_FILE_RAW && > + S_ISBLK(sb.st_mode)) { > + qemuDomainObjPrivatePtr priv = vm->privateData; > + if (qemuDomainObjBeginJob(vm) < 0) > + goto cleanup; > + > + qemuDomainObjEnterMonitor(vm); > + ret = qemuMonitorGetBlockExtent(priv->mon, > + disk->info.alias, > + &info->allocation); that means you now propagate that fatal error out of the call, rather than falling back on the default.