On 05/20/2014 07:36 AM, Peter Krempa wrote:
When doing an external checkpoint of a VM with no disk selected
we'd
return failure but not set error code. This was a result of ret not
being set to 0 during walking of the disk array.
Rework early failure checking to avoid the problem.
Fixes the following symptom (or without --diskspec for diskless VMs)
$ virsh snapshot-create-as snapshot-test --memspec /tmp/asdf --diskspec
hda,snapshot=no
error: An error occurred, but the cause is unknown
---
Technically, this is equivalent to a 'virsh save'. Would it be better
to avoid an error altogether and allow the operation as a longhand
spelling of the same action?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org