Re: [libvirt] [PATCH] allow '#' as valid character for domain name

On 11/19/2010 11:00 AM, Laine Stump wrote: >> -<param name="pattern">[A-Za-z0-9_\.\+\-&amp;:/]+</param> >> +<param name="pattern">[A-Za-z0-9_\.\+\-\\#&amp;:/]+</param> >> </data> >> </define> >> <define name="diskSerial"> > > What's your motivation for this? > > If domain.rng is used similarly to the other .rng files I'm more > familiar with, it's only actually examined during the tests run as part > of "make check", so it won't have any effect on actual operation. Is > this what you intended? Additionally, it would be a good idea to add a .xml file somewhere in the tests/ hierarchy that has such a domain name, as a way of getting test exposure of both the RelaxNG schema validation and of actual XML handling in libvirt itself.

> "#" seems like a problematic character to put in a domain name - for > example it would need to be escaped or quoted if it was ever on a > commandline Only if it is the first character of the domain name, but yes, this aspect alone makes me need to see a concrete example of someone using a domain like this before we can add support for it.

$ echo #ab $ echo a#b a#b -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list