On Tue, Jul 31, 2018 at 17:42:50 +0800, Yi Min Zhao wrote:
在 2018/7/30 下午11:12, Peter Krempa 写道:
> Jansson does not put a newline at the end of formatted JSON strings.
> This breaks the qemucapsprobe utility as we need to keep the spacing so
> that tests work. Add an explicit newline.
>
> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
> ---
> tests/qemucapsprobemock.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/qemucapsprobemock.c b/tests/qemucapsprobemock.c
> index 5936975505..049b16273a 100644
> --- a/tests/qemucapsprobemock.c
> +++ b/tests/qemucapsprobemock.c
> @@ -76,6 +76,7 @@ qemuMonitorSend(qemuMonitorPtr mon,
> printLineSkipEmpty("\n", stdout);
>
> printLineSkipEmpty(reformatted, stdout);
> + printLineSkipEmpty("\n", stdout);
> VIR_FREE(reformatted);
>
> return realQemuMonitorSend(mon, msg);
> @@ -116,6 +117,7 @@ qemuMonitorJSONIOProcessLine(qemuMonitorPtr mon,
> printLineSkipEmpty("\n", stdout);
>
> printLineSkipEmpty(json, stdout);
> + printLineSkipEmpty("\n", stdout);
> }
>
> cleanup:
I have a question. Could this problem(I mean miss \n) trigger qemuxml2*test
can't run?
No. This tool is used to generate the data for the qemucapabilitiestest and
only manually so unless you are gathering new qemu caps testing data
that binary is not even run.
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list