Re: mingw rpm build busted? (was: Release of libvirt-9.9.0)
On Wed, Nov 01, 2023 at 05:21:18PM -0400, Cole Robinson wrote:
On 11/1/23 11:02 AM, Daniel P. Berrangé wrote:
> On Wed, Nov 01, 2023 at 10:54:25AM -0400, Cole Robinson wrote:
>> RPM build is busted in mingw meson step. rawhide log:
>> https://kojipkgs.fedoraproject.org//work/tasks/8354/108418354/build.log
>>
>> Error is:
>>
>> ../meson.build:2050:4: ERROR: Problem encountered: cannot enable
>> expensive tests when tests are disabled
>>
>> I'm getting it on up to date f38 as well. Anyone else seeing this? meson
>> 1.2.3 and 1.2.2 both affected
>
> That will be exposed by
>
> ommit 8ce0decc372051d616018f57ae268e2f03082eec
> Author: Andrea Bolognani <abologna(a)redhat.com>
> Date: Tue Oct 3 14:53:08 2023 +0200
>
> meson: Make -Dexpensive_tests depend on -Dtests
>
> It only makes sense to enable expensive tests when tests are
> enabled. Disallow invalid configurations.
>
> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
> Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com>
> Reviewed-by: Martin Kletzander <mkletzan(a)redhat.com>
>
> the bug is that libvirt.spec.in is passing
>
> -Dexpensive_tests=enabled \
> -Dtests=disabled \
>
> to %mingw_meson which is a nonsensical combniation. Flip expensive tests
> to disabled for mingw.
Thanks Daniel, that fixes things for me
Apologies for failing to take into consideration the MinGW part of
the spec file. Again.
On the other hand, I think this highlights the fact that our coverage
in the area is not adequate.
Patches to fix the issue you've reported and hopefully ensure that
similar mistakes will not sneak in going forward:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/Y2...
--
Andrea Bolognani / Red Hat / Virtualization