Re: [libvirt] [PATCH] Add capabilities bit for -no-kvm-pit-reinjection
On 02/18/2013 01:10 AM, Doug Goldstein wrote:
The conversion to qemuCaps dropped the ability with qemu{,-kvm} 1.2
and
newer to set the lost tick policy for the PIT. While the
-no-kvm-pit-reinjection option is depreacated, it is still supported at
least through 1.4, it is better to not lose the functionality.
After 1.4 will adding it to a commandline result in an error, or will it
be ignored?
Also, will something else be replacing it, or is it just no longer
useful/necessary?
It would be a bit perturbing if an "implied" capability disappeared,
with no way to detect via QMP whether or not it was there.
---
src/qemu/qemu_capabilities.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 51fc9dc..af52bbf 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -2284,6 +2284,7 @@ virQEMUCapsInitQMPBasic(virQEMUCapsPtr qemuCaps)
virQEMUCapsSet(qemuCaps, QEMU_CAPS_NO_USER_CONFIG);
virQEMUCapsSet(qemuCaps, QEMU_CAPS_NETDEV_BRIDGE);
virQEMUCapsSet(qemuCaps, QEMU_CAPS_SECCOMP_SANDBOX);
+ virQEMUCapsSet(qemuCaps, QEMU_CAPS_NO_KVM_PIT);
}