Re: [PATCH 1/2] docs: Rework documentation for the NSS module
On Wed, Nov 13, 2024 at 11:57:10AM +0100, Michal Prívozník wrote:
On 11/13/24 11:35, Andrea Bolognani wrote:
> +Note that this feature only works in certain scenarios. See the
> +`limitations <#limitations>`__ section for more information.
syntax check is not happy with this style of linking:
libvirt.git/docs/nss.rst:22:`limitations <#limitations>`__ section for more
information.
libvirt.git/docs/nss.rst:50:(see `below <#variants>`_ for differences between the
two) will be used
make: Leaving directory 'libvirt.git/_build/build-aux'
stderr:
use local reference within a file
make: *** [libvirt.git/build-aux/syntax-check.mk:1136:
sc_avoid_remote_reference_to_local_file] Error 1
Good catch! The error message is not super actionable, so I'll try to
cook a small patch improving that while I'm at it.
> +Installing the module on Fedora or RHEL is really easy:
Since you're changing this to RHEL/Fedora specifically ..
> # yum install libvirt-nss
.. I'd also s/yum/dnf/
Fair enough. I thought yum was still the preferred command for RHEL,
but I just checked the official documentation and indeed as of RHEL 9
that's no longer the case.
Fixed everything and pushed. Thanks for the quick and thorough
review!
--
Andrea Bolognani / Red Hat / Virtualization