Re: [libvirt] [PATCH python] include usable memory in virDomainMemoryStats

On 08/01/2017 03:23 PM, Tomáš Golembiovský wrote: > Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com&gt; > --- > libvirt-override.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libvirt-override.c b/libvirt-override.c > index 0abfc37..832e05c 100644 > --- a/libvirt-override.c > +++ b/libvirt-override.c > @@ -398,6 +398,9 @@ libvirt_virDomainMemoryStats(PyObject *self ATTRIBUTE_UNUSED, > case VIR_DOMAIN_MEMORY_STAT_RSS: > key = libvirt_constcharPtrWrap("rss"); > break; > + case VIR_DOMAIN_MEMORY_STAT_USABLE: > + key = libvirt_constcharPtrWrap("usable"); > + break; > default: > continue; > } > Almost. Firstly, there's VIR_DOMAIN_MEMORY_STAT_LAST_UPDATE which is not handled either. Secondly, these two macros were introduced in libvirt 2.1.0. So we need a check that enables them iff building with 2.1.0 or newer. I'm fixing both issues and pushing. I wonder if there's something we can do to not forget about macros like these again.