Re: [libvirt] [PATCH 00/19] Rollback migration when libvirtd restarts
On Mon, Jul 11, 2011 at 21:33:41 +0100, Daniel P. Berrange wrote:
On Fri, Jul 08, 2011 at 01:34:05AM +0200, Jiri Denemark wrote:
> This series is also available at
> https://gitorious.org/~jirka/libvirt/jirka-staging/commits/migration-reco...
>
> The series does several things:
> - persists current job and its phase in status xml
> - allows safe monitor commands to be run during migration/save/dump jobs
> - implements recovery when libvirtd is restarted while a job is active
> - consolidates some code and fixes bugs I found when working in the area
>
> The series is not perfect and still needs some corner cases to be fixed but I
> think it's better to send the series for review now and add small additional
> fixes in the next version(s) instead of waiting for it to be perfect.
What level of testing has it had so far ? In particular does it pass the
giant migration test case in the TCK ?
Only manual testing so far with a special focus on failed migration and
recovery/rollback. I tested successful migrations as well, but only a limited
set of options of normal/p2p migration and libvirt was exactly the same
version for client/source/dest. I still need to run this through the migration
test case, but I don't have a setup for that though. Could you run this easily
through the beast? That would be perfect but if not, I'll create the setup for
it and run it myself.
Jirka