Re: [libvirt] [PATCH] qemu: fix QEMU_CAPS_NO_ACPI detection
On Fri, Dec 21, 2012 at 10:37 PM, Viktor Mihajlovski <
mihajlov(a)linux.vnet.ibm.com> wrote:
On 12/21/2012 03:07 PM, Li Zhang wrote:
>
> Will it get QEMU_CAPS_NO_ACPI capability by QMP if S390 doesn't support
> ACPI?
> I test it on PPC, it won't get this capability by QMP.
>
> In the QMP case, basic capabilities are not being probed, but assumed
to be present, however -no-acpi is only valid for x86, hence the
conditional setting.
You mean it still is present. I didn't get it on POWER.
The old help parsing code on older QEMUs could report -no-acpi for
S390 (respectively non-x86), which has to be removed from the
capability set to avoid errors starting the guest.
On POWER, QEMU's help string doesn't include -no-acpi.
It seems that QEMU handles this differently. :)
--
Mit freundlichen Grüßen/Kind Regards
Viktor Mihajlovski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
--
Best Regards
-Li
Attachments:
- attachment.html (text/html — 2.1 KB)