Re: [libvirt] [PATCH v2 06/13] squash into rendernode capability patch

On Wed, Nov 28, 2018 at 03:13:29PM +0100, Peter Krempa wrote: > On Wed, Nov 28, 2018 at 14:38:16 +0100, Erik Skultety wrote: > > Signed-off-by: Erik Skultety <eskultet(a)redhat.com&gt; > > This needs to be commited as a separate patch adding the caps and not > squashed into any random capability addition. > > You seem to be missing the VMX capability, did you create this on a VM? > > I have a version of this now with vmx which is identical except for that > fact, so I can post that if you don't want to bother to create this in > real hardware. > > Otherwise, ACK. The VMX capability is actually there. We're in a freeze, so depends whether you feel like SFF or not.