Re: [libvirt] [PATCH] phyp: avoid a crash

2011/5/12 Eric Blake <eblake(a)redhat.com&gt;: > This has been present since the introduction of phypAttachDevice > in commit 444fd07a. > > * src/phyp/phyp_driver.c (phypAttachDevice): Don't dereference > NULL. Your patch doesn't make it worse as it already is and it avoids a segfault. Yes, the virDomainDefPtr handling needs improvement. ACK, to the fix of the directly problem here.