Re: [libvirt] [PATCH 1/4] qemu: make qemuDomainHelperGetVcpus silent
On Fri, Sep 19, 2014 at 11:44:20AM +0200, Francesco Romani wrote:
The commit 74c066df4d8 introduced an helper to factor a code path
which is shared between the existing API and the new bulk stats API.
In the bulk stats path errors must be silenced unless critical
(e.g. memory allocation failure).
To address this need, this patch adds an argument to disable error reporting.
I'm really don't like the approach of adding 'bool reportError' flags to
internal functions as it doesn't scale. These flags end up creeping out
across more & more of the code base and different callers are going to
disagree about which errors should be ignored and which not. Having the
callers use virResetError is preferrable IMHO as it avoids polluting
countless internal functions with ill defined args.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|