Re: [PATCH] qemu: Don't double free @node_cpus in qemuProcessSetupPid()
On 4/23/21 10:56 AM, Ján Tomko wrote:
On a Friday in 2021, Michal Privoznik wrote:
> When placing vCPUs into CGroups the qemuProcessSetupPid() is
> called which then enters a for() loop (around its middle) where
> it calls virDomainNumaGetNodeCpumask() for each guest NUMA node.
> But the latter returns only a pointer not new reference/copy and
> thus the caller must not free it. But the variable is decorated
> with g_autoptr() which leads to a double free.
>
> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
Fixes: 2d37d8dbc987d1998b4ad8029ba324b6bfe49799
Yeah, I thought about adding it here, but then figured it's int the same
release as this patch is going to be. And I guess nobody backports
features. So what are the rules for putting "fixes"?
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Pushed, thanks.
Michal