Re: [libvirt] [PATCH 1/7] screenshot: Defining the public API
On 04/01/2011 09:29 AM, Michal Privoznik wrote:
---
include/libvirt/libvirt.h.in | 7 +++++++
src/libvirt_public.syms | 1 +
2 files changed, 8 insertions(+), 0 deletions(-)
Hmm, we've already declared 0.9.0 feature freeze;
+++ b/src/libvirt_public.syms
@@ -428,6 +428,7 @@ LIBVIRT_0.9.0 {
global:
virDomainGetBlkioParameters;
virDomainMigrateSetMaxSpeed;
+ virDomainScreenshot;
virDomainSetBlkioParameters;
virDomainSetMemoryFlags;
virEventRegisterDefaultImpl;
So this needs to be reworked to start a new section for LIBVIRT_0.9.1,
and defer this series until after the release. While it's probably a
low-risk API addition, we're setting a bad precedent if we let this in
this late after the release candidate and this close to the final release.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)