Re: [libvirt] [libvirt PATCH v2 03/44] Force QMP capability probing
On Mon, 2018-04-09 at 16:42 +0100, Daniel P. Berrangé wrote:
> @@ -5114,7 +4261,7 @@ virQEMUCapsNewForBinaryInternal(virArch
hostArch,
> goto error;
> }
>
> - if (qmpOnly && !qemuCaps->usedQMP) {
> + if (!qemuCaps->usedQMP) {
> virReportError(VIR_ERR_INTERNAL_ERROR,
> _("Failed to probe QEMU binary with QMP: %s"),
> qmperr ? qmperr : _("unknown error"));
We should be able to kill this now. We only have "usedQMP" because we
want to gracefully get out of virQEMUCapsInitQMPCommandRun() when
launching with QMP fails. We can make that method return -1 or 0 only
now, and drop "usedQMP"
I assumed he would drop it later in the series. Even if that's not
the case, I'd still rather see it dropped as a follow-up cleanup
patch instead of cramming even more changes into this single commit.
--
Andrea Bolognani / Red Hat / Virtualization