Re: [libvirt] [PATCH v2 0/4] Adjustment to recent cgroup/cpuset changes (for 1.3.1)
On Thu, Jan 14, 2016 at 06:14:45PM +0100, Henning Schild wrote:
On Thu, 14 Jan 2016 16:42:12 +0000
"Daniel P. Berrange" <berrange(a)redhat.com> wrote:
> On Thu, Jan 14, 2016 at 11:21:25AM -0500, John Ferlan wrote:
> > v1:
> > http://www.redhat.com/archives/libvir-list/2016-January/msg00511.html
> >
> > As discussed during the replies of the v1 - revert Henning's first
> > two patches, plus the one I made as a result of those.
> >
> > Patch 4/4 is already ACK'd
> >
> > John Ferlan (4):
> > Revert "qemu: do not put a task into machine cgroup"
> > Revert "util: cgroups do not implicitly add task to new machine
> > cgroup"
> > Revert "lxc_cgroup: Add check for NULL cgroup before AddTask call"
> > cgroup: Fix possible bug as a result of code motion for vcpu
> > cgroup setup
>
> ACK to all
Same here!
Daniel do you want to fix the "first qemu thread is no emulator" issue,
or should i give it another try?
If you send another patch I'll review it. As mentioned before, I think
i'd suggest something as simple as calling qemuCgroupSetupEmulator
from qemuInitCgroup will probably work ok
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|