Re: [libvirt] [PATCH] libxl: do not use hardcoded pygrub path

Hi Jim, thanks four your time. Some replies inline, but before let me clarify some things: - I am running libvirt + xen in Debian and Ubuntu hosts. - /usr/bin/pygrub does not exist in Debian and Ubuntu, it is located in /usr/lib/xen-<version>/bin/pygrub instead. - We have been running our guests without including a bootloader element in the XML files until we have migrated to libxl. On Tue 19 Aug 2014 (23:15), Jim Fehlig wrote: AFAIK if the bootloader is not set, or if it is set to just "pygrub", xend searchs for it [1] in several locations [2]. If it is set to a full path, it does not search for anything and uses that path. In our case we didn't set a bootloader and xend finds it in LIBEXEC (that in Debian/Ubuntu using Xen 4.4 points to /usr/lib/xen-4.4/bin/). [1] http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=tools/python/xen/xend/X... [2] http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=tools/python/xen/util/a... libvirt using libxl is setting the bootloader to /usr/bin/pygrub if it is not set in the XML file. This produces the following warning in the libvirt logs (coming from libxl [3]): libxl: warning: libxl_bootloader.c:413:bootloader_disk_attached_cb: bootloader='/usr/bin/pygrub' is deprecated; use bootloader='pygrub' instead The boot process finally ends up failing since it cannot find /usr/bin/pygrub libxl: cannot execute /usr/bin/pygrub: No such file or directory Therefore I assume that when libxl sets the bootloader because it is missing in the XML file it should set it just to "pygrub" not "/usr/bin/pygrub", hence my patch, but maybe I am mistaken. [3] http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=tools/libxl/libxl_bootl... Thanks for the clarification. See my comments above, if not specified or if it is only "pygrub" xend searchs for it in any of the expected paths. Actually just one issue apart from the warning in the log: After the migration from xend to libxl I am not able to boot anymore one of the previously running guests. I have to set manually in each of the guests' configuration the bootloader, pointing to the correct location. Kind regards, -- Álvaro López García aloga(a)ifca.unican.es Instituto de Física de Cantabria http://alvarolopez.github.io Ed. Juan Jordá, Campus UC tel: (+34) 942 200 969 Avda. de los Castros s/n 39005 Santander (SPAIN)