Re: [libvirt] [PATCH 0/5] network: define new API virNetworkDefineXMLFlags
On 08/20/2012 02:17 AM, Laine Stump wrote:
I would like to enhance libvirt's network API to allow enacting
any
changes in definition immediately, as an alternative to the current
behavior of saving the changes right away, but not using them until
the next time the network is destroyed and re-started.
This could easily be handled by a flag passed to
virNetworkDefineXML(). Unfortunately, virNetworkDefineXML() was added
to libvirt before we came up with the idea of adding a flags arg to
every new API (just for things like this). To remedy this, I've
effectively duplicated that API with a new API,
virNetworkDefineXMLFlags(), which currently behaves identically, but
has an extra "flags" argument.
danpb has convinced me that it's better not to overload virNetworkDefine
in this way, but instead to have a separate API similar to
virDomain(Attach|Update|Detach)Device, so I'm withdrawing this patch,
and will post a query in a separate thread about these new APIs.