Re: [libvirt PATCH v2 2/2] ci: Drop env variables related to autotools and make
On Mon, 2020-11-09 at 12:20 +0100, Erik Skultety wrote:
Previous patch switched the build to meson which supports only
out-of-tree builds, runs by default in parallel on all available CPUs,
and we don't use configure anymore - the corresponding variables are
thus longer needed.
Signed-off-by: Erik Skultety <eskultet(a)redhat.com>
---
ci/Makefile | 29 -----------------------------
1 file changed, 29 deletions(-)
The changes look good, so
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
to those.
However, since you don't have such a clean separation between the two
patches (you already drop some autotools-related stuff in first one)
I would suggest just squashing them together.
--
Andrea Bolognani / Red Hat / Virtualization