Re: [PATCH 1/2] vbox: Fix memleak in _virtualboxCreateMachine()

The _virtualboxCreateMachine() function allocates @createFlagsUtf16 but never frees it. ==12481== 236 bytes in 2 blocks are definitely lost in loss record 2,060 of 2,216 ==12481== at 0x48407E5: malloc (vg_replace_malloc.c:393) ==12481== by 0xB6C6D1B: RTStrToUtf16Tag (utf-8.cpp:1033) ==12481== by 0xB4DB500: _virtualboxCreateMachine (vbox_tmpl.c:634) ==12481== by 0xB4E68A3: vboxDomainDefineXMLFlags (vbox_common.c:1976) ==12481== by 0x4C7DF83: virDomainDefineXMLFlags (libvirt-domain.c:6666) ==12481== by 0x13C2DA: remoteDispatchDomainDefineXMLFlags (remote_daemon_dispatch_stubs.h:5271) ==12481== by 0x13C265: remoteDispatchDomainDefineXMLFlagsHelper (remote_daemon_dispatch_stubs.h:5252) ==12481== by 0x4AD9DF7: virNetServerProgramDispatchCall (virnetserverprogram.c:428) ==12481== by 0x4AD9931: virNetServerProgramDispatch (virnetserverprogram.c:302) ==12481== by 0x4AE28AC: virNetServerProcessMsg (virnetserver.c:135) ==12481== by 0x4AE2972: virNetServerHandleJob (virnetserver.c:155) ==12481== by 0x49BC275: virThreadPoolWorker (virthreadpool.c:164) Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt;

--- src/vbox/vbox_tmpl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 52b1c93b6d..91609741e3 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -626,6 +626,7 @@ _virtualboxCreateMachine(struct _vboxDriver *data, virDomainDef *def, IMachine * machine); VIR_FREE(createFlags); VBOX_UTF16_FREE(machineNameUtf16); + VBOX_UTF16_FREE(createFlagsUtf16); vboxIIDUnalloc(&iid); return rc; } -- 2.39.1