Re: [libvirt] [PATCH 00/15] NEWS: Plenty of fixes and improvements
On Wed, Oct 14, 2015 at 10:35:56AM +0200, Andrea Bolognani wrote:
Oh boy, where to start :)
Patch 01 fixes the XSLT stylesheet used to generate the
plain text NEWS file from docs/news.html.in. This has
been broken for at least two years, based on the oldest
release archive available on the website.
Patches 02-05 clean up some very simple mistakes.
Patches 06-09 are the juicy bits: very old entries were
not as tidy as recent ones, so I went through them and
polished them up to bring them up to standard. It would
be great if someone who was around from the early days,
ideally DV, could go over patch 09 in particular, since
categorizing old changes I know barely nothing about is
by definition prone to error.
I don't think you need to worry about that since you kept most of them
categorized as they were.
Patches 10-15 go over everything one last time for that
extra shiny finish.
Cheers.
PS: Patch 07 contains an awfully long line that
git-send-email warns me about. I'll try to sent it
anyway, but if it doesn't make it to the list
that's probably the reason.
I see you followed the majority with your decisions, so that's good,
even though in some cases some new wind would be nice, but that can be
done after this series. I feel like we all agree about the future
split and so there is no need for waiting till we reach a consensus.
So ACK from me, with all the things that I pointed out fixed (unless
they are fixed in another patch and I missed that). It'd be also nice
to leave the first patch at the end or after the split, as mentioned
in reply to that particular patch.
I leave it up to you whether you want to wait for anyone else's
cross-check (multiple puns intended).
Have a pleasant day,
Martin
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)