Re: [libvirt] Extend virConfParser to allow parsing VMware VMX config files

2009/6/19 Daniel P. Berrange <berrange(a)redhat.com&gt;: > On Fri, Jun 19, 2009 at 10:01:20AM +0200, Matthias Bolte wrote: >> Hi, >> >> As part of the VMware ESX driver I need to parse VMware VMX config >> files. This files have basically the same syntax as Xen config files, >> but the key part of the key=value format is allowed to contain ':' and >> '.'. >> >> The attached patch adds a flag to the virConfParser to enabled a VMX >> mode for the parser to allow ':' and '.' in the key, as suggested by >> Daniel P. Berrange on IRC. > > ACK, looks fine to me - though I'm wondering if you might also want to > explicitly turn off support for lists ? IIIRC the VMware config values > were only scalars, so for safety you might want the parser to refuse > to parse / generate lists. > > Daniel > Good advice. I've done this now and attached the patch for it. The first patch got already commited, thanks to Daniel Veillard.