Re: [libvirt] [PATCH] esx: Restrict vpx:// to handle a single host in a vCenter

On Sun, Aug 01, 2010 at 02:20:22AM +0200, Matthias Bolte wrote: > Now a vpx:// connection has an explicitly specified host. This > allows to enabled several functions for a vpx:// connection > again, like host UUID, hostname, general node info, max vCPU > count, free memory, migration and defining new domains. > > Lookup datacenter, compute resource, resource pool and host > system once and cache them. This simplifies the rest of the > code and reduces overall HTTP(S) traffic a bit. > > esx:// and vpx:// can be mixed freely for a migration. > > Ensure that migration source and destination refer to the > same vCenter. Also directly encode the resource pool and > host system object IDs into the migration URI in the prepare > function. Then directly build managed object references in > the perform function instead of re-looking up already known > information. > --- >  docs/drvesx.html.in          |   33 +++- >  src/esx/esx_driver.c         |  360 ++++++++++---------------- >  src/esx/esx_storage_driver.c |   24 +-- >  src/esx/esx_vi.c             |  588 ++++++++++++++++++++++++++---------------- >  src/esx/esx_vi.h             |   26 ++- >  src/esx/esx_vmx.c            |    4 + >  6 files changed, 561 insertions(+), 474 deletions(-)  Humpf, that was big ! ACK it seems to me that this change the behaviour of vServer access, so I'm tempted to get this pushed in 0.8.3, rather than wait for the next version to change things. On one hand this breaks the freeze, but this is focused to one specific kind of hypervisor whose support is being added, so I think this is fine to push before the release if you agree, Daniel