Re: [libvirt] [PATCH] security: AppArmor profile fixes for swtpm
On Mon, Sep 16, 2019 at 03:27:25PM +0200, Chris Coulson wrote:
The AppArmor profile generated by virt-aa-helper is too strict for
swtpm.
This change contains 2 small fixes:
- Relax append access to swtpm's log file to permit write access instead.
Append access is insufficient because the log is opened with O_CREAT.
- Permit swtpm to acquire a lock on its lock file.
Thanks for submitting this patch. As written on our governance page [1], particularly
under contributors [2], this project requires providing a Signed-off-by as an agreement
with the Developer Certificate of Origin [3].
If you can resend the patches with that change (easily with git commit --amend, very
easily with a silly command-line [4]) I will merge this patch.
Have a nice day,
Martin
[1] https://libvirt.org/governance.html
[2] https://libvirt.org/governance.html#contributors
[3] https://developercertificate.org/
[4] EDITOR='git interpret-trailers --in-place --trailer
"Signed-off-by=..."' git commit --amend
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)