Re: [libvirt PATCH 3/6] meson: merge all cc_flags arrays into one

On Thu, Apr 08, 2021 at 11:58:20AM +0100, Daniel P. Berrangé wrote: > The split of arrays is fairly arbitrary and a hang over from the way we > had to structure lists of flags when we used GNULIB's compiler flag > checking m4 logic. > > The separate lists leads to cases where we enable a flag in one list and > have contradictory setting in another list, which leads to confusion. > > Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; > --- > meson.build | 116 +++++++++++++++++++--------------------------------- > 1 file changed, 43 insertions(+), 73 deletions(-) > > diff --git a/meson.build b/meson.build > index 97d9c52165..55dde6d963 100644 > --- a/meson.build > +++ b/meson.build > @@ -211,7 +211,23 @@ if git_werror.enabled() or git_werror.auto() and git > cc_flags += [ '-Werror' ] > endif

I would keep the comment here as well. # This should be < 256 really. Currently we're down to 4096, # but using 1024 bytes sized buffers (mostly for virStrerror) # stops us from going down further

> + '-Wframe-larger-than=4096', > '-Wfree-nonheap-object', > '-Whsa', > '-Wif-not-aligned', > '-Wignored-attributes',