Re: [libvirt] [PATCH v2 00/10] Restore code to allow unpriv_sgio for hostdev SCSI generic

On Mon, Jul 06, 2015 at 13:08:28 -0400, John Ferlan wrote: Well, I'm not going to insist that we revert the existing code since it's possible that the feature might actually make it into the upstream linux kernel eventually. Until it's upstream I don't think though we should add support (even if we document that it will not work) for stuff that is not upstream since the design of the upstream interface might then differ, which will make us carry two implementations. Since there's already existing code that touches the kernel interface for unpriv_sgio, actually exposing the support will then require us to carry that part instead of changing it to the actual upstream impl. If a "hypothetical" downstream distro would add kernel patches to add the feature, they might as well as carry the downstream libvirt patches too. NACK series until upstream kernel support is present. (Some of the cleanup patches may be worth taking until the kernel issue gets settled though.) Peter