Re: [libvirt] [PATCH v3 0/2] Rework RPC message buffer

On 05/31/2012 08:48 AM, Michal Privoznik wrote: > This patch set tries to fix corner cases where libvirt runs on huge > system, e.g. 4K CPU monster. In these cases, capabilities XML is > enormously big, as we are transferring info about each singe CPU core > (to which NUMA node it belongs, etc.). This XML is bigger than our > RPC limit, therefore users cannot get it as it is dropped on server, > leaving them with inability to connect. Therefore we need to increase > those limits (whole RPC message and RPC string). However, simple > lifting up will work, but increase mem usage. > > Therefore I've reworked RPC buffer handling: changed it from > 'statically' to dynamically allocated. > So in most cases - when small messages are sent - this will even > decrease our memory consumption. Leaving us flexible for corner cases > described above. > > On the other hand, I realize we've had our history with RPC breakage. > So I think I'll require more than 1 ACK before pushing. > (I guess Eric's ACK still holds) Yes, ACK series, as I checked... > > diff to v2: > -suggestions from Eric's review included that you did indeed cover my points from v2. I'd like to maximize our testing of this feature - if you don't have a second review by next Tuesday morning, then go ahead and push with just my review. (Hopefully you'll get a second review over the weekend or on Monday)