[libvirt] [PATCH v2 2/3] test: Use virDomainObjListFindByIDRef
Rather than using virDomainObjListFindByID, let's be more consistent
and return a reffed and locked object. Since we're using the Ref API,
use virDomainObjEndAPI on @dom and not just virObjectUnlock.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
src/test/test_driver.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 0cacab2fde..3c01aa50e1 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -1720,16 +1720,14 @@ static virDomainPtr testDomainLookupByID(virConnectPtr conn,
virDomainPtr ret = NULL;
virDomainObjPtr dom;
- if (!(dom = virDomainObjListFindByID(privconn->domains, id))) {
+ if (!(dom = virDomainObjListFindByIDRef(privconn->domains, id))) {
virReportError(VIR_ERR_NO_DOMAIN, NULL);
- goto cleanup;
+ return NULL;
}
ret = virGetDomain(conn, dom->def->name, dom->def->uuid,
dom->def->id);
- cleanup:
- if (dom)
- virObjectUnlock(dom);
+ virDomainObjEndAPI(&dom);
return ret;
}
--
2.13.6