Re: [libvirt] [PATCH v2 10/12] qemu: split getting stats for migration and others
On 16.02.2017 18:47, Jiri Denemark wrote:
On Wed, Dec 28, 2016 at 17:39:19 +0300, Nikolay Shirokovskiy wrote:
> All domain jobs other than source migration have only one
> state - active. Only elapsed time is available for such
> jobs so let's make it more explicit. Also if in future there will
> be more stats for such jobs we don't want to mess them with
> migration stats code.
> ---
> src/qemu/qemu_driver.c | 58 ++++++++++++++++++++++++++++++++------------------
> 1 file changed, 37 insertions(+), 21 deletions(-)
NACK, see my reply to 8/12.
Can you please clarify? It is not that related to 8 patch as I see it. It basically
just creates separate function for getting migration stats.
Nikolay