Re: [libvirt] [RFC PATCH 1/4] powerpc: Use Sysfs to gather host info

On Sat, Oct 08, 2011 at 12:07:08AM +0530, Prerna Saxena wrote: > Libvirt presently depends on /proc/cpuinfo to gather information about > the x86 host. Parsing of /proc/cpuinfo is arch-specific; the > information fields are also not consistent. > A cleaner way would be to use Sysfs. Both x86 and PowerPC specific > information can be obtained from sysfs with different arch specific > parsing routines. > > --- > src/nodeinfo.c | 106 +++++++++++++++++++------------------------------------- > 1 files changed, 36 insertions(+), 70 deletions(-) > > diff --git a/src/nodeinfo.c b/src/nodeinfo.c > index 6448b79..cdd339d 100644 > ...[snip]... I checked the output of 'virsh nodeinfo' before and after this patch on RHEL5 and RHEL-6 hosts, and it did not change.

When building, however, you get a compiele warning about the unused parameter 'need_hyperthreads'. How come this was needed before, but is not used anymore ? If it is redundant, you should remove the parameter entirely.