Re: [libvirt] [PATCH v2 0/5] Add "rawio" for hostdev

On 09/19/2014 12:17 PM, John Ferlan wrote: > v1 is here: > http://www.redhat.com/archives/libvir-list/2014-September/msg00502.html > > Changes since v1 (from code review): > > * Insert patch 1 to insert a missing goto if rawio is set, but the > build doesn't suport CAP_SYS_RAWIO. > * Insert patch 2 to use the TristateBool for virDomainDiskDef and > the associated changes where it's used in code > * Patch 3, 4, 5: Use TristateBool for hostdev rawio and the virYesNo > in the rng > > John Ferlan (5): > qemu: Add missing goto on rawio > domain_conf: Change virDomainDiskDef 'rawio' to use virTristateBool > hostdev: Add "rawio" attribute to _virDomainHostdevSubsysSCSI I think the above commit should be squashed with the domain_conf patch below. > qemu: Process the hostdev "rawio" setting And this one moved to the end, since it depends on it. > domain_conf: Process the "rawio" for a hostdev device > > docs/formatdomain.html.in | 12 +++++-- > docs/schemas/domaincommon.rng | 12 +++++-- > src/conf/domain_conf.c | 40 +++++++++++++++------- > src/conf/domain_conf.h | 4 +-- > src/qemu/qemu_domain.c | 23 +++++++++++-- > src/qemu/qemu_domain.h | 4 +++ > src/qemu/qemu_driver.c | 1 + > src/qemu/qemu_process.c | 23 ++++++++++++- > .../qemuxml2argv-hostdev-scsi-rawio.xml | 35 +++++++++++++++++++ > tests/qemuxml2xmltest.c | 1 + > 10 files changed, 132 insertions(+), 23 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-rawio.xml > ACK series Jan