Re: [PATCH 4/7] spec: Move lockd plugin to a new subpackage libvirt-daemon-plugin-lockd

On Tue, Dec 13, 2022 at 09:55:19AM +0000, Daniel P. Berrangé wrote: > On Mon, Dec 12, 2022 at 03:39:44PM -0700, Jim Fehlig wrote: > > > > +%files daemon-plugin-lockd > > > > +%dir %attr(0755, root, root) %{_libdir}/libvirt/lock-driver > > > > > > I believe this directory belongs to either the libvirt-daemon-lock > > > package (more likely) or possibly the libvirt-daemon-common package. > > > > Yep, I think libvirt-daemon-lock is correct. Thanks a lot for the review and > > comments! > > libvirt-daemon-lock isn't the right place, as that's the home > for virtlockd. > > This directory is what contains either lockd.so or sanlock.so, > which are both client side plugins for other daemons. virlockd is the one that's going to load the plugins, so I don't think it's necessarily wrong for its package to own the directory.