Re: [libvirt] [PATCH] virsh: add qemu-monitor-command --pretty

On Thu, Oct 04, 2012 at 05:22:20PM -0600, Eric Blake wrote: > I was using qemu-monitor-command during development, and found it quite > hard to use. Compare the results of this patch on ease of reading: >

> Note that 'qemu-monitor-command dom --pretty --hmp info version' > happens to truncate 0.12.1(qemu-kvm-0.12.1.2) into just 0.12 (since > that is the portion of the prefix of the string that forms a valid > JSON subsequence); we probably have a bug in virJSONValueFromString > for not rejecting trailing junk, but that's a matter for another > patch; for now, I just documented that --hmp and --pretty don't > make sense together in the man page. I'd tweak the patch to reject the combination of --hmp and --pretty; other than that it looks like a great readability enhancement.

> > -=item B<qemu-monitor-command> I<domain> [I<--hmp>] I<command>... > +=item B<qemu-monitor-command> I<domain> { [I<--hmp>] | [I<--pretty>] }