Re: [libvirt PATCH 00/20] Switch to json-c from yajl
On Wed, Aug 14, 2024 at 23:40:15 +0200, Ján Tomko wrote:
As requested by:
https://gitlab.com/libvirt/libvirt/-/issues/581
The ci update depends on the following libvirt-ci MR:
https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/497
targets: bump OpenSUSE Leap to 15.6
Pipeline:
https://gitlab.com/janotomko/libvirt/-/pipelines/1413887401/
Ján Tomko (20):
tests: json: relax some test cases
ci: update OpenSUSE Leap to 15.6
util: json: introduce virJSONStringPrettifyBlanks
tests: switch to compact empty JSON object formatting
meson: add option for building with json-c
meson: link libvirt with json_c if available
util: json: write a json-c implementation
ci: install json-c too
meson: nss: link with json-c if available
nss: convert findLeases to use json-c
nss: convert findMACs to use json-c
tests: depend on WITH_JSON_C instead of WITH_YAJL
meson: switch checks to depend on json-c instead of yajl
meson-options: switch to depend on json-c instead of yajl
libvirt-spec: switch to building with json-c
meson: do not link anything with yajl anymore
meson: options: drop yajl
meson: drop yajl detection
util: drop dead code
ci: drop yajl completely
Overall looks good to me but there are few loose ends in terms of
building with the NSS modules as they don't have another implementation
for the switchover but are rather rewritten at once, which could pose
problems if rebasing across this series.
I suggest you enforce, for the duration of the series that both yajl and
json-c are installed if either of them is selected.
Als some of the meson patches could really be squashed together.