Re: [libvirt] PATCH: Misc fixes to qparams
On Thu, May 22, 2008 at 12:49:04AM +0100, Daniel P. Berrange wrote:
- In the qparam_query_parse() method, after appending each
(name,value)
pair of params, it failed to free the temporary buffers for the
(name,value) pair.
- Did not allow for ';' as a valid query parameter separator
- In a couple of OOM cleanup scenarios it failed to free buffers allocated
earlier on
Yes this code looks fine to me.
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top