Re: [libvirt] [PATCHv5 0/8] bulk stats: QEMU implementation

From: "Peter Krempa" <pkrempa(a)redhat.com&gt; To: "Francesco Romani" <fromani(a)redhat.com&gt;, libvir-list(a)redhat.com Sent: Monday, September 15, 2014 2:25:08 PM Subject: Re: [libvirt] [PATCHv5 0/8] bulk stats: QEMU implementation

> ChangeLog > > v5: address reviewer's comment > - Eric pointed out a possible flaw in balloon stats if QEMU monitor needs > to be queried. A proper fix require further discussion and API changes > (possbily just a new flag); However, since the balloon event is available > in QEMU >= 1.2, I just dropped the query and relied on the event instead. > Support for older QEMUs will be reintroduced, if needed, with following > patches. > - fix: per-domain monitor check and reporting. (pointed out by Peter) > - reset last error when fail silently. (pointed out by Peter) The changes look good. I've done a few finishing touches and I'm going to give the series some testing before pushing. The series should be pushed by today after I finish. Thanks for your cooperation in finishing this.