Re: [libvirt] [PATCH] Fix a memory leak in the node_device_udev code

On 04/28/2010 02:27 PM, Chris Lalancette wrote: > We were over-writing a pointer without freeing it in > case of a disk device, leading to a memory leak. > > Signed-off-by: Chris Lalancette <clalance(a)redhat.com&gt; > --- > src/node_device/node_device_udev.c | 7 ------- > 1 files changed, 0 insertions(+), 7 deletions(-) Plugging a memory leak by pure code deletion - nice :) I had to double-check, but concur that udevProcessDisk is static, and the only caller already had data->storage.drive_type set to "disk" on entry. ACK. > - data->storage.drive_type = strdup("disk");