Re: [libvirt] [PATCH] virt-login-shell joins users into lxc container.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 07/25/2013 01:23 PM, Eric Blake wrote:
On 07/25/2013 11:09 AM, Eric Blake wrote:
>>
>> ACK to this patch.
>>
>> Technically since we're post freeze we shouldn't commit this until
>> 1.1.2, but since this is an entirely new program perhaps we could make
>> an exception here ? Thoughts ?
>
> It was posted pre-freeze; the only reason it didn't make freeze was lack
> of timely review.
That said, since the patch adds a setuid binary, I would like to review it
as a second set of eyes before we push it.
The code was sent to a few reviewers, but I have not heard back, I will
resend the latest code.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlHxX4oACgkQrlYvE4MpobMKhgCguv0ydgBjcEkC5Kxf/rt3OAwv
u4gAn0bA6VM83MJm91dc5gOSC9gJpdcu
=lA4e
-----END PGP SIGNATURE-----