Re: [libvirt] [PATCH v4 3/9] qemu: Implement the qemu driver fetch for IOThreads

> > The maplen is not needed. Just pass 'hostcpus' to > 'virProcessGetAffinity' and it will generate a virBitmap of the right > size, then virBitmapToData computes the correct maplen. > >> + maxcpu = maplen * 8; >> + if (maxcpu > hostcpus) > > These two lines are redundant. > If maplen * 8 < hostcpus, then VIR_CPU_MAPLEN is flawed, because the map > does not hold at least hostcpus bits. > If maplen * 8 >= hostcpus, the value of hostcpus is used. > Hmm... I'll have to go back and look again as this was pretty much following the VcpuPin or EmulatorPin examples with a touch of GetCPUMap since this code returns the cpumap rather than expecting one on input.