Re: [PATCH] Added support for disk model string for QEMU IDE and SATA devices
On Tue, Jul 18, 2023 at 22:39:26 +0200, Benedek Major wrote:
The QEMU drivers ide-hd and ide-cd used for IDE and SATA bus devices
support
adding a disk model that is returned on guest query by the IDE or SATA disk to the
guest.
The already existing product tag got changed to allow for up to 40 characters,
which is the maximum allowed by the specification, if the controller is set to SATA or
IDE.
If set, the product gets passed to QEMU using the -model parameter.
The product represents the model until command creation,
where it gets processed depending on the current type of disk controller.
Dead code checking for QEMU version 1.2.0 got removed, since minimum is 4.2.0.
I've posted proper patches to do this part properly as I've originally
replied in the review.
I'll rebase this patch on top of that series so that it's done properly.
I'll also also adjust the commit message to go along with that, so
there's no need to resend.
Signed-off-by: Benedek Major <benedek(a)major.onl>
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>
---
src/conf/domain_validate.c | 18 +++++++++++++++---
src/qemu/qemu_command.c | 8 ++++++--
src/qemu/qemu_validate.c | 28 +++++++++++++---------------
3 files changed, 34 insertions(+), 20 deletions(-)