Re: [libvirt] [jenkins-ci PATCH v3 08/10] lcitool: refactor logic for building package list
On Wed, 2019-02-13 at 19:03 +0000, Daniel P. Berrangé wrote:
[...]
+ pkgname = temp[item]
+ if pkgname is None:
+ continue
+ if pkgname not in pkgs:
+ pkgs.append(pkgname)
I think this would look slightly better as
if pkgname is None:
continue
if pkgname in pkgs:
continue
pkgs.append(pkgname)
Regardless of whether you change it or keep it as-is,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization